-
Notifications
You must be signed in to change notification settings - Fork 7.6k
Update esptool v5 as an package #92894
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Update esptool v5 as an package #92894
Conversation
The following west manifest projects have changed revision in this Pull Request:
Additional metadata changed:
⛔ DNM label due to: 1 project with PR revision and 1 project with metadata changes Note: This message is automatically posted and updated by the Manifest GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you said you were going to add this dependency in the hal_espressif module?
Something like https://github.com/zephyrproject-rtos/nanopb/blob/master/zephyr/module.yml#L5-L8
The current esptool-5.0.0 has a bug that affects some Zephyr builds; therefore, we need to wait for the fix, which will be released as |
e49e04c
to
f86d481
Compare
Brings changes in how esptool is istalled in the environment. Signed-off-by: Marek Matej <marek.matej@espressif.com>
Updated requirements-actions.in,txt to fetch esptool for the CI. Fix format of the arguments used in the esptool-5.0.0. TODO: esptool>=5.0.1 is required, which was not yet released Signed-off-by: Marek Matej <marek.matej@espressif.com>
f86d481
to
89cd47f
Compare
|
This PR brings the changes in how the esptool is installed in the system. Instead of hard-copy in the hal/espressif, it put the esptool on the list of required packages. This reflects the new esptool v5.0.0, which comes with several breaking changes.